Skip to content

OWNERS_ALIASES: replace Benjamin2037 with bb7133 - #70416

Merged
ti-chi-bot[bot] merged 1 commit into
release-7.5from
update-owner-aliases-bb7133-release-7.5
Aug 27, 2026
Merged

OWNERS_ALIASES: replace Benjamin2037 with bb7133#70416
ti-chi-bot[bot] merged 1 commit into
release-7.5from
update-owner-aliases-bb7133-release-7.5

Conversation

@wuhuizuo

@wuhuizuo wuhuizuo commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #70419

Problem Summary:

Replace member Benjamin2037 with bb7133 in OWNERS_ALIASES, deduplicating members within each SIG. sig-community-* entries are left untouched (they are synced from pingcap/community).

What changed and how does it work?

  • OWNERS_ALIASES: Benjamin2037 -> bb7133 in all SIGs except sig-community-*; removed duplicate bb7133 entries where the same SIG already listed it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

OWNERS_ALIASES replaces Benjamin2037 with bb7133 in twelve SIG approver groups.

Changes

SIG approver alias updates

Layer / File(s) Summary
Update SIG approver memberships
OWNERS_ALIASES		 The distsql, lightning, ddl, disttask, dumpling, infoschema, meta, owner, resourcemanager, table, lock, and tidb-binlog approver lists now use bb7133.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: type/enhancement

Poem

A rabbit checks the aliases bright,
bb7133 joins the list tonight.
Twelve SIG groups now point the way,
With tidy approvals in array.
Hop, hop—ownership is clear!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change by identifying the alias file and the member replacement.
Description check ✅ Passed The description includes the issue reference, problem, implementation details, testing decision, side effects, documentation, and release note sections.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-owner-aliases-bb7133-release-7.5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 10, 2026
@wuhuizuo wuhuizuo added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 11, 2026
bb7133
bb7133 approved these changes Aug 11, 2026
View reviewed changes

@bb7133 bb7133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified the scoped OWNERS_ALIASES identity replacement and per-SIG deduplication; sig-community aliases are untouched.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot

ti-chi-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-08-11 03:38:01.205694472 +0000 UTC m=+3104067.241789518: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 11, 2026
@wuhuizuo wuhuizuo added the lgtm label Aug 26, 2026
@ti-chi-bot ti-chi-bot Bot removed the lgtm label Aug 26, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

@wuhuizuo: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so.

Details

In response to adding label named lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 27, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit aa508ab into release-7.5 Aug 27, 2026
3 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the update-owner-aliases-bb7133-release-7.5 branch August 27, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wuhuizuo @bb7133 @ti-chi-bot